Tidy lingering connection/REPL terminology#4034
Merged
Merged
Conversation
Follow-up to the connection->REPL/session rename. Align the internal names and docstrings that still said "connection" where a REPL buffer is meant: - rename the internal `cider-trace--connection' var to `cider-trace--repl' - rename the `current-connection' local in `cider--modeline-info' to `current-repl' - docstring wording in `cider-map-repls', `cider-repl-type-for-buffer', `cider-repl-type-override', `cider--extract-connections' and the modeline helper No behavior change. Public `*-connection*` names are left alone (a connection genuinely is a concept, and they're part of the API).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the connection -> REPL/session rename, from a terminology audit of the session layer. Aligns the internal names and docstrings that still said "connection" where a REPL buffer is actually meant - no behavior change, no public API touched:
cider-trace--connectionvar tocider-trace--replcurrent-connectionlocal incider--modeline-infotocurrent-replcider-map-repls(a-replsfunction that said "connections"),cider-repl-type-for-buffer/cider-repl-type-override("connection type" -> "REPL type"),cider--extract-connections, and the modeline helperDeliberately left alone: the public
*-connection*surface (cider-describe-connection,cider-connected-p,cider-connect-*, thecider-connected-hook/cider-disconnected-hookdefcustoms, etc.) - a connection genuinely is a real concept (1:1 with a REPL by CIDER's own definition) and these are API/keybindings. The one public symbol whose name arguably contradicts its concept iscider-ensure-connected(it ensures a session); left as-is since renaming public API needs an alias + deprecation cycle - flagging it for a separate decision.